- https://jakehamilton.dev
- Joined on
2024-05-21 -
-
D'oh! Thank you for catching this. Not sure why my brain decided to cross those wires 😅
Oh weird, I thought I made this comment around like 216 where lib.types.submodules.of was used. Sorry for the confusion.
I think that all makes sense, thanks for the informative answer! One…
Can we extract the builtins.map doNamespace flattened bit to a variable so that this value is easier to read? Something like builtins.seq throwOnConflict namespacedModules might make it easier to understand.
Can we wrap usage of or in parens here? It can be a bit confusing otherwise.
nit: maybe a name like createNamespacedModule would be informative here?
There may be issues with this approach if we end up doing shorthand syntax for all modules. I don't think that we will, but submodules do support it for convenience. I wonder if we can have a different kind of object used for namespaces includes. What about something like:
Neat! I would mention that it is worth being extremely cautious introducing options, especially under the aux namespace. These are probably fine, but it is worth considering how things may shape…