auxolotl/labs
20
5
Fork 1
Code Issues Pull requests 1 Actions Packages Projects Releases Wiki Activity

foundation/stage0: fix hex0 hashes for amd64 & arm64 #2

Merged
jakehamilton merged 1 commit from srd424/fix-hex0 into main 2024-06-17 10:59:53 +00:00
Conversation 2 Commits 1 Files changed 1 +2 -2
srd424 commented 2024-06-16 19:13:37 +00:00
Member
Copy link

I must confess to not understanding quite how all this works, but this seems to solve the problem of aarch64 fetching the x86-64 binary and vice-versa.

I must confess to not understanding quite how all this works, but this seems to solve the problem of aarch64 fetching the x86-64 binary and vice-versa.
srd424 added 1 commit 2024-06-16 19:13:37 +00:00
srd424 commented 2024-06-16 20:11:03 +00:00
Author
Member
Copy link

nixpkgs has them the other way around: d850b620ed/pkgs/os-specific/linux/minimal-bootstrap/stage0-posix/hex0.nix (L12)

nixpkgs has them the other way around: https://github.com/NixOS/nixpkgs/blob/d850b620edda71029fef64e2c2715fe809f68dbd/pkgs/os-specific/linux/minimal-bootstrap/stage0-posix/hex0.nix#L12
jakehamilton commented 2024-06-16 20:35:34 +00:00
Owner
Copy link

nixpkgs has them the other way around: d850b620ed/pkgs/os-specific/linux/minimal-bootstrap/stage0-posix/hex0.nix (L12)

Oh my gosh. I think I get this then. Nix is doing the thing where it takes the hash provided to the fetcher and does a lookup. Then since it got a got it uses the cached value. UGH.

Thanks for catching this, not sure when I got them mixed up, but we can swap them around to be correct. Oops!

> nixpkgs has them the other way around: https://github.com/NixOS/nixpkgs/blob/d850b620edda71029fef64e2c2715fe809f68dbd/pkgs/os-specific/linux/minimal-bootstrap/stage0-posix/hex0.nix#L12 Oh my gosh. I think I get this then. Nix is doing the thing where it takes the hash provided to the fetcher and does a lookup. Then since it got a got it uses the cached value. UGH. Thanks for catching this, not sure when I got them mixed up, but we can swap them around to be correct. Oops!
jakehamilton approved these changes 2024-06-16 20:36:03 +00:00
jakehamilton left a comment
Owner
Copy link

Thank you for catching this!

Thank you for catching this!
jakehamilton merged commit 8e9cb4fbe9 into main 2024-06-17 10:59:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jakehamilton
Labels
Clear labels
  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: auxolotl/labs#2
No description provided.
Delete branch "srd424/fix-hex0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?