Jake Hamilton jakehamilton · they/he
0 followers · 0 following
Repositories Projects Packages Code Public activity Starred repositories
2
jakehamilton commented on pull request auxolotl/infra#6 2024-06-29 19:19:29 +00:00
feat(keys): Add coded SSH keys for infra

Commenting here to ACK that I saw this 👍

jakehamilton created branch feat/transient-deps in auxolotl/labs 2024-06-24 21:37:47 +00:00
jakehamilton pushed to feat/transient-deps at auxolotl/labs 2024-06-24 21:37:47 +00:00
2be3111b2c wip: working single dependency reference via coercion
jakehamilton pushed to main at auxolotl/labs 2024-06-23 18:39:33 +00:00
8233d4aedf use correct name for topological sort (#5)
jakehamilton merged pull request auxolotl/labs#5 2024-06-23 18:39:31 +00:00
use correct name for topological sort
jakehamilton approved auxolotl/labs#5 2024-06-23 18:39:20 +00:00
use correct name for topological sort

D'oh! Thank you for catching this. Not sure why my brain decided to cross those wires 😅

jakehamilton merged pull request auxolotl/labs#4 2024-06-23 17:32:12 +00:00
Fix non-deterministic "missing: Permission denied" errors
jakehamilton pushed to main at auxolotl/labs 2024-06-23 17:32:12 +00:00
a2f0a06426 Fix non-deterministic "missing: Permission denied" errors (#4)
jakehamilton approved auxolotl/labs#4 2024-06-23 17:32:01 +00:00
Fix non-deterministic "missing: Permission denied" errors

Thanks for digging into this!

jakehamilton pushed to main at auxolotl/labs 2024-06-22 17:58:49 +00:00
a707b0f06b refactor: format all nix code
jakehamilton pushed to main at auxolotl/labs 2024-06-22 17:56:24 +00:00
3479354ec9 refactor: add formatting script
jakehamilton pushed to main at auxolotl/labs 2024-06-22 17:43:52 +00:00
403420fd4b fix: missing semicolon
jakehamilton pushed to main at auxolotl/labs 2024-06-22 16:11:40 +00:00
9316874396 fix: add missing prefix for submodules, incorrect var name
dc2ce818b8 feat: apply dag defaults
69a8760bd3 feat: working linux-headers build
Compare 3 commits »
jakehamilton commented on pull request auxolotl/labs#3 2024-06-19 19:02:52 +00:00
WIP: feat: Namespaced includes

Oh weird, I thought I made this comment around like 216 where lib.types.submodules.of was used. Sorry for the confusion.

I think that all makes sense, thanks for the informative answer! One…

jakehamilton commented on pull request auxolotl/labs#3 2024-06-18 16:36:23 +00:00
WIP: feat: Namespaced includes

Is this comment needed?

jakehamilton commented on pull request auxolotl/labs#3 2024-06-18 16:36:23 +00:00
WIP: feat: Namespaced includes

Can we wrap usage of or in parens here? It can be a bit confusing otherwise.

jakehamilton commented on pull request auxolotl/labs#3 2024-06-18 16:36:23 +00:00
WIP: feat: Namespaced includes

nit: maybe a name like createNamespacedModule would be informative here?

jakehamilton commented on pull request auxolotl/labs#3 2024-06-18 16:36:23 +00:00
WIP: feat: Namespaced includes

Can we extract the builtins.map doNamespace flattened bit to a variable so that this value is easier to read? Something like builtins.seq throwOnConflict namespacedModules might make it easier to understand.

jakehamilton commented on pull request auxolotl/labs#3 2024-06-18 16:36:22 +00:00
WIP: feat: Namespaced includes

There may be issues with this approach if we end up doing shorthand syntax for all modules. I don't think that we will, but submodules do support it for convenience. I wonder if we can have a different kind of object used for namespaces includes. What about something like:

jakehamilton commented on pull request auxolotl/labs#3 2024-06-18 16:36:22 +00:00
WIP: feat: Namespaced includes

What is the rationale for this being a submodule?