auxolotl/wiki
20
0
Fork 0
Code Issues Pull requests Projects Releases Packages Activity Actions

feat: Add editorconfig #5

Closed
dfh wants to merge 2 commits from dfh/fix-editorconfig into main
Conversation 3 Commits 2 Files changed 1 +16
dfh commented 2024-08-02 00:20:34 +00:00
Member

Aligned with the global recommendations from https://wiki.auxolotl.org/en/contributing/formatting/editorconfig

This is related to PR4:
prettier loads and uses language specific formatting settings from .editorconfig files.

Please ignore the failing tests, they are result of PR4 being work-in-progress.

Aligned with the global recommendations from https://wiki.auxolotl.org/en/contributing/formatting/editorconfig This is related to [PR4](https://git.auxolotl.org/auxolotl/wiki/pulls/4): `prettier` loads and uses language specific formatting settings from `.editorconfig` files. Please ignore the failing tests, they are result of [PR4](https://git.auxolotl.org/auxolotl/wiki/pulls/4) being work-in-progress.
dfh added 1 commit 2024-08-02 00:20:35 +00:00 
Aligned with the global recommendations from https://wiki.auxolotl.org/en/contributing/formatting/editorconfig
requested reviews from minion, coded 2024-08-02 00:20:53 +00:00
removed review requests for minion, coded 2024-08-02 01:36:06 +00:00
dfh changed title from feat: Add editorconfig to WIP: feat: Add editorconfig 2024-08-02 01:36:09 +00:00
dfh commented 2024-08-02 01:37:54 +00:00
Author
Member

Downgrading to WiP status, since I'm running into issues with the integration of prettier and editorconfig

Downgrading to WiP status, since I'm running into issues with the integration of prettier and editorconfig
dfh added 1 commit 2024-08-02 20:03:40 +00:00 
As discussed in [1] and per the new formatting policy [2]



[1] https://matrix.to/#/!YfU2d0xXyRXv6FB8e9:auxolotl.org/$ixiOU4nC5YwV13rteiSZ8NO2oBUDOylFPsiDf4BkZnc?via=auxolotl.org&via=matrix.org&via=krab.chat
[2] b3fe093ca5
dfh changed title from WIP: feat: Add editorconfig to feat: Add editorconfig 2024-08-02 20:04:01 +00:00
dfh commented 2024-08-02 20:06:15 +00:00
Author
Member

Prettier issue resolved with change to formatting guidelines

Prettier issue resolved with change to [formatting guidelines](https://git.auxolotl.org/auxolotl/wiki/commit/b3fe093ca58c05f1ae73e9316c135be51a96d844)
dfh commented 2024-08-02 22:41:33 +00:00
Author
Member

After more reviewing I decided to merge this PR with PR#4.

Closing without commit.

After more reviewing I decided to merge this PR with [PR#4](https://git.auxolotl.org/auxolotl/wiki/pulls/4). Closing without commit.
dfh closed this pull request 2024-08-02 22:41:33 +00:00
dfh deleted branch dfh/fix-editorconfig 2024-08-02 23:28:02 +00:00
Some checks reported errors
buildbot/nix-build .#checks.x86_64-darwin Build done.
Details
buildbot/nix-build .#checks.x86_64-linux Build done.
Details
buildbot/nix-eval Build done.
Details
buildbot/nix-build .#checks.aarch64-darwin Build done.
Details
buildbot/nix-build .#checks.aarch64-linux Build done.
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No labels
Compat
Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: auxolotl/wiki#5
No description provided.
Delete branch "dfh/fix-editorconfig"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?