auxolotl/buildbot-nix

push-pxqquzvulpou #3

Open

minion wants to merge 2 commits from push-pxqquzvulpou into main

minion commented

2024-09-11 20:20:15 +00:00

Owner

No description provided.

minion added 2 commits 2024-09-11 20:20:16 +00:00

feat!: Update output path writing 46800094bb

- Allow pull requests to create output paths

Previously, it was not possible to get unmerged pull request outputs. I
would like to access these (e.g. for hosting a preview version of a
website in a similar way to https://docs.netlify.com/site-deploys/deploy-previews/
or https://vercel.com/docs/deployments/preview-deployments)

These are now surfaced under `{owner}/{repo}/pulls/{pr number}`

- Fix repository attribute name conflicts

Previously there was no difference between samely-named attributes in
different repositories.

This has been changed so outputs are under `{owner}/{repo}/{branch}`

- Allow full attribute names, still stripping path traversal

Previously, presumably to prevent path traversal, if your attribute name
contained slashes buildbot-nix would only take the last segment as an
output.

This has been replaced by interpreting slashes as subdirectories and
refusing any segments which don't descend into a subdirectory (i.e. are
attempting path traversal)

- Still create outputs on skipped builds

Previously when something was skipped, for example a build that was
completed in a pull request, the output wouldn't be updated. This made
the outputs directory quite unreliable.

Outputs will now always be updated, no matter whether a build was
actually executed.

BREAKING-CHANGE: This stops old output locations being outputted. If you rely on these locations, you will need to update whatever relies on them.

fix: Correct output path with failed builds

buildbot/nix-eval Build done.

Details

Previously, if a build failed to produce any output we would try to
write "None" to the output file. This doesn't work, causing the job to
error. Instead, we should skip writing the output and preserve the
original "failed" status.

minion force-pushed push-pxqquzvulpou from a0784bf027 to a5b34ea356

2024-09-11 20:54:26 +00:00

Compare

This pull request has changes conflicting with the target branch.

buildbot_nix/__init__.py

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin push-pxqquzvulpou:push-pxqquzvulpou

git checkout push-pxqquzvulpou

Merge

Merge the changes and update on Forgejo.

git checkout main

git merge --no-ff push-pxqquzvulpou

git checkout main

git merge --ff-only push-pxqquzvulpou

git checkout push-pxqquzvulpou

git rebase main

git checkout main

git merge --no-ff push-pxqquzvulpou

git checkout main

git merge --squash push-pxqquzvulpou

git checkout main

git merge --ff-only push-pxqquzvulpou

git checkout main

git merge push-pxqquzvulpou

git push origin main

Sign in to join this conversation.

No reviewers

No labels

Kind/Documentation

Kind/Enhancement

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: auxolotl/buildbot-nix#3

No description provided.