Fix links to github sources (#232)

This commit is contained in:
Marek Fajkus 2020-11-24 00:06:41 +01:00 committed by GitHub
parent 8dd69e68c1
commit ecf71f5932
Failed to generate hash of commit
3 changed files with 15 additions and 8 deletions

View file

@ -33,6 +33,7 @@ import Html.Attributes
( class
, colspan
, href
, target
)
import Html.Events
exposing
@ -218,7 +219,9 @@ viewResultItemDetails channel item =
case Search.channelDetailsFromId channel of
Just channelDetails ->
a
[ href <| githubUrlPrefix channelDetails.branch ++ (value |> String.replace ":" "#L") ]
[ href <| githubUrlPrefix channelDetails.branch ++ (value |> String.replace ":" "#L")
, target "_blank"
]
[ text <| value ]
Nothing ->

View file

@ -34,6 +34,7 @@ import Html.Attributes
( class
, colspan
, href
, target
)
import Html.Events
exposing
@ -248,18 +249,18 @@ viewResultItemDetails channel item =
githubUrlPrefix branch =
"https://github.com/NixOS/nixpkgs/blob/" ++ branch ++ "/"
cleanPosition value =
if String.startsWith "source/" value then
String.dropLeft 7 value
else
value
cleanPosition =
Regex.fromString "^[0-9a-f]+\\.tar\\.gz\\/"
|> Maybe.withDefault Regex.never
>> (\reg -> Regex.replace reg (\_ -> ""))
asGithubLink value =
case Search.channelDetailsFromId channel of
Just channelDetails ->
a
[ href <| githubUrlPrefix channelDetails.branch ++ (value |> String.replace ":" "#L" |> cleanPosition) ]
[ href <| githubUrlPrefix channelDetails.branch ++ (value |> String.replace ":" "#L" |> cleanPosition)
, target "_blank"
]
[ text <| cleanPosition value ]
Nothing ->

View file

@ -264,6 +264,9 @@ type Channel
| Release_20_09
{-| TODO: we should consider using more dynamic approach here
and load channels from apis similar to what status page does
-}
type alias ChannelDetails =
{ id : String
, title : String