Some frontend cleanup (#459)

* remove Debug.log statements

* move View.Components.SearchInput.viewBucket into Search module

* combine 2 version of viewSearchInput

* moving viewFlakes function to Search module

and removing View.Components.SearchInput module

* removing View.Components module

* use :: instead of List.append

frontend/src/Main.elm

@@ -162,19 +162,12 @@ attemptQuery (( model, _ ) as pair) =
 
         Flakes (PackagesModel searchModel) ->
             if Search.shouldLoad searchModel then
-                -- let
-                --     _ = Debug.log "main" "submit flake message"
-                -- in
                 submitQuery FlakesMsg Page.Flakes.makeRequest { searchModel | channel = defaultFlakeId }
 
             else
-                --   let _ = Debug.log "main" "should not load flakes" in
                 noEffects pair
 
         _ ->
-            -- let
-            --  _ = Debug.log "pair" <| Debug.toString pair
-            -- in
             pair
 
 
@@ -268,7 +261,6 @@ changeRouteTo currentModel url =
 
                 Route.Flakes searchArgs ->
                     let
-                        -- _ = Debug.log "changeRouteTo" "flakes"
                         modelPage =
                             case model.page of
                                 Flakes x ->
@@ -285,8 +277,6 @@ changeRouteTo currentModel url =
 
 update : Msg -> Model -> ( Model, Cmd Msg )
 update msg model =
-    -- let _ = Debug.log "main" "update"
-    -- in
     case ( msg, model.page ) of
         ( ClickedLink urlRequest, _ ) ->
             case urlRequest of

frontend/src/Page/Flakes.elm

@@ -12,20 +12,33 @@ import Html
     exposing
         ( Html
         , a
+        , div
+        , h1
         , strong
         , text
         )
-import Html.Attributes exposing (href)
+import Html.Attributes
+    exposing
+        ( class
+        , href
+        )
+import Html.Events exposing (onClick)
 import Http exposing (Body)
 import Page.Options exposing (Msg(..))
 import Page.Packages exposing (Msg(..))
+import RemoteData exposing (RemoteData(..))
 import Route
     exposing
         ( Route(..)
         , SearchType(..)
         )
 import Search
-import View.Components
+    exposing
+        ( Msg(..)
+        , viewFlakes
+        , viewResult
+        , viewSearchInput
+        )
 
 
 
@@ -124,8 +137,21 @@ update navKey msg model =
 view : Model -> Html Msg
 view model =
     let
-        mkBody categoryName =
-            View.Components.body { toRoute = Route.Flakes, categoryName = categoryName }
+        resultStatus result =
+            case result of
+                RemoteData.NotAsked ->
+                    "not-asked"
+
+                RemoteData.Loading ->
+                    "loading"
+
+                RemoteData.Success _ ->
+                    "success"
+
+                RemoteData.Failure _ ->
+                    "failure"
+
+        bodyTitle =
             [ text "Search packages and options of "
             , strong []
                 [ a
@@ -134,6 +160,23 @@ view model =
                 ]
             ]
 
+        mkBody categoryName model_ viewSuccess viewBuckets outMsg =
+            div
+                (List.append
+                    [ class <| "search-page " ++ resultStatus model_.result ]
+                    (if model_.showSort then
+                        [ onClick (outMsg ToggleSort) ]
+
+                     else
+                        []
+                    )
+                )
+                [ h1 [] bodyTitle
+                , viewSearchInput outMsg categoryName Nothing model_.query
+                , viewResult outMsg Route.Flakes categoryName model_ viewSuccess viewBuckets <|
+                    viewFlakes outMsg model_.channel model_.searchType
+                ]
+
         body =
             case model of
                 OptionModel model_ ->

frontend/src/Page/Packages.elm

@@ -52,9 +52,9 @@ import Search
     exposing
         ( Details(..)
         , decodeResolvedFlake
+        , viewBucket
         )
 import Utils
-import View.Components.SearchInput exposing (viewBucket)
 
 
 
@@ -167,9 +167,6 @@ init searchArgs model =
     let
         ( newModel, newCmd ) =
             Search.init searchArgs model
-
-        -- _ =
-        --     Debug.log "New package model" newModel
     in
     ( newModel
     , Cmd.map SearchMsg newCmd

frontend/src/Search.elm

@@ -11,6 +11,7 @@ module Search exposing
     , Sort(..)
     , channelDetailsFromId
     , channels
+    , closeButton
     , decodeAggregation
     , decodeResolvedFlake
     , decodeResult
@@ -26,7 +27,10 @@ module Search exposing
     , trapClick
     , update
     , view
+    , viewBucket
+    , viewFlakes
     , viewResult
+    , viewSearchInput
     )
 
 import Base64
@@ -74,7 +78,12 @@ import Json.Decode
 import Json.Decode.Pipeline
 import Json.Encode
 import RemoteData
-import Route exposing (SearchType)
+import Route
+    exposing
+        ( SearchType
+        , allTypes
+        , searchTypeToTitle
+        )
 import Route.SearchQuery
 import Set
 import Task
@@ -398,10 +407,6 @@ update toRoute navKey msg model =
                 |> pushUrl toRoute navKey
 
         QueryResponse result ->
-            -- let
-            -- _ =
-            --     Debug.log "got query result" result
-            -- in
             ( { model
                 | result = result
               }
@@ -768,11 +773,42 @@ view { toRoute, categoryName } title model viewSuccess viewBuckets outMsg search
             )
         )
         [ h1 [] title
-        , viewSearchInput outMsg categoryName model.channel model.query
+        , viewSearchInput outMsg categoryName (Just model.channel) model.query
         , viewResult outMsg toRoute categoryName model viewSuccess viewBuckets searchBuckets
         ]
 
 
+viewFlakes :
+    (Msg a b -> msg)
+    -> String
+    -> SearchType
+    -> List (Html msg)
+viewFlakes outMsg _ selectedCategory =
+    [ li []
+        [ ul []
+            (List.map
+                (\category ->
+                    li []
+                        [ a
+                            [ href "#"
+                            , onClick <| outMsg (SubjectChange category)
+                            , classList
+                                [ ( "selected"
+                                  , category == selectedCategory
+                                  )
+                                ]
+                            ]
+                            [ span [] [ text <| searchTypeToTitle category ]
+                            , closeButton
+                            ]
+                        ]
+                )
+                allTypes
+            )
+        ]
+    ]
+
+
 viewResult :
     (Msg a b -> c)
     -> Route.SearchRoute
@@ -871,10 +907,62 @@ viewNoResults categoryName =
         ]
 
 
+closeButton : Html a
+closeButton =
+    span [] []
+
+
+viewBucket :
+    String
+    -> List AggregationsBucketItem
+    -> (String -> a)
+    -> List String
+    -> List (Html a)
+    -> List (Html a)
+viewBucket title buckets searchMsgFor selectedBucket sets =
+    List.append
+        sets
+        (if List.isEmpty buckets then
+            []
+
+         else
+            [ li []
+                [ ul []
+                    (List.append
+                        [ li [ class "header" ] [ text title ] ]
+                        (List.map
+                            (\bucket ->
+                                li []
+                                    [ a
+                                        [ href "#"
+                                        , onClick <| searchMsgFor bucket.key
+                                        , classList
+                                            [ ( "selected"
+                                              , List.member bucket.key selectedBucket
+                                              )
+                                            ]
+                                        ]
+                                        [ span [] [ text bucket.key ]
+                                        , if List.member bucket.key selectedBucket then
+                                            closeButton
+
+                                          else
+                                            span [] [ span [ class "badge" ] [ text <| String.fromInt bucket.doc_count ] ]
+                                        ]
+                                    ]
+                            )
+                            buckets
+                        )
+                    )
+                ]
+            ]
+        )
+
+
 viewSearchInput :
     (Msg a b -> c)
     -> String
-    -> String
+    -> Maybe String
     -> Maybe String
     -> Html c
 viewSearchInput outMsg categoryName selectedChannel searchQuery =
@@ -882,7 +970,7 @@ viewSearchInput outMsg categoryName selectedChannel searchQuery =
         [ onSubmit (outMsg QueryInputSubmit)
         , class "search-input"
         ]
-        [ div []
+        (div []
             [ div []
                 [ input
                     [ type_ "text"
@@ -897,8 +985,11 @@ viewSearchInput outMsg categoryName selectedChannel searchQuery =
             , button [ class "btn", type_ "submit" ]
                 [ text "Search" ]
             ]
-        , div [] (viewChannels outMsg selectedChannel)
-        ]
+            :: (selectedChannel
+                    |> Maybe.map (\x -> [ div [] (viewChannels outMsg x) ])
+                    |> Maybe.withDefault []
+               )
+        )
 
 
 viewChannels :

frontend/src/View/Components.elm

@@ -1,35 +0,0 @@
-module View.Components exposing (body)
-
-import Html exposing (Html)
-import Route exposing (SearchRoute)
-import Search
-    exposing
-        ( Details
-        , Model
-        , Msg
-        , ResultItem
-        , SearchResult
-        )
-import View.Components.Body
-
-
-body :
-    { toRoute : SearchRoute, categoryName : String }
-    -> List (Html c)
-    -> Model a b
-    ->
-        (String
-         -> Details
-         -> Maybe String
-         -> List (ResultItem a)
-         -> Html c
-        )
-    ->
-        (Maybe String
-         -> SearchResult a b
-         -> List (Html c)
-        )
-    -> (Msg a b -> c)
-    -> Html c
-body =
-    View.Components.Body.view

frontend/src/View/Components/Body.elm

@@ -1,78 +0,0 @@
-module View.Components.Body exposing (view)
-
-import Html
-    exposing
-        ( Html
-        , div
-        , h1
-        )
-import Html.Attributes exposing (class)
-import Html.Events exposing (onClick)
-import RemoteData exposing (RemoteData(..))
-import Route
-import Search
-    exposing
-        ( Details
-        , Model
-        , Msg(..)
-        , ResultItem
-        , SearchResult
-        , viewResult
-        )
-import View.Components.SearchInput
-    exposing
-        ( viewFlakes
-        , viewSearchInput
-        )
-
-
-view :
-    { toRoute : Route.SearchRoute
-    , categoryName : String
-    }
-    -> List (Html c)
-    -> Model a b
-    ->
-        (String
-         -> Details
-         -> Maybe String
-         -> List (ResultItem a)
-         -> Html c
-        )
-    ->
-        (Maybe String
-         -> SearchResult a b
-         -> List (Html c)
-        )
-    -> (Msg a b -> c)
-    -> Html c
-view { toRoute, categoryName } title model viewSuccess viewBuckets outMsg =
-    let
-        resultStatus =
-            case model.result of
-                RemoteData.NotAsked ->
-                    "not-asked"
-
-                RemoteData.Loading ->
-                    "loading"
-
-                RemoteData.Success _ ->
-                    "success"
-
-                RemoteData.Failure _ ->
-                    "failure"
-    in
-    div
-        (List.append
-            [ class <| "search-page " ++ resultStatus ]
-            (if model.showSort then
-                [ onClick (outMsg ToggleSort) ]
-
-             else
-                []
-            )
-        )
-        [ h1 [] title
-        , viewSearchInput outMsg model.searchType model.query
-        , viewResult outMsg toRoute categoryName model viewSuccess viewBuckets <| viewFlakes outMsg model.channel model.searchType
-        ]

frontend/src/View/Components/SearchInput.elm

@@ -1,156 +0,0 @@
-module View.Components.SearchInput exposing
-    ( closeButton
-    , viewBucket
-    , viewFlakes
-    , viewSearchInput
-    )
-
-import Html
-    exposing
-        ( Html
-        , a
-        , button
-        , div
-        , form
-        , input
-        , li
-        , span
-        , text
-        , ul
-        )
-import Html.Attributes
-    exposing
-        ( autofocus
-        , class
-        , classList
-        , href
-        , id
-        , placeholder
-        , type_
-        , value
-        )
-import Html.Events
-    exposing
-        ( onClick
-        , onInput
-        , onSubmit
-        )
-import Route
-    exposing
-        ( SearchType
-        , allTypes
-        , searchTypeToString
-        , searchTypeToTitle
-        )
-import Search exposing (Msg(..))
-
-
-viewSearchInput :
-    (Msg a b -> c)
-    -> SearchType
-    -> Maybe String
-    -> Html c
-viewSearchInput outMsg category searchQuery =
-    let
-        searchHint =
-            Maybe.withDefault "Packages and Options" <| Maybe.map (\_ -> searchTypeToString category) searchQuery
-    in
-    form
-        [ onSubmit (outMsg QueryInputSubmit)
-        , class "search-input"
-        ]
-        [ div []
-            [ div []
-                [ input
-                    [ type_ "text"
-                    , id "search-query-input"
-                    , autofocus True
-                    , placeholder <| "Search for " ++ searchHint
-                    , onInput (outMsg << QueryInput)
-                    , value <| Maybe.withDefault "" searchQuery
-                    ]
-                    []
-                ]
-            , button [ class "btn", type_ "submit" ]
-                [ text "Search" ]
-            ]
-        ]
-
-
-viewFlakes : (Msg a b -> msg) -> String -> SearchType -> List (Html msg)
-viewFlakes outMsg _ selectedCategory =
-    [ li []
-        [ ul []
-            (List.map
-                (\category ->
-                    li []
-                        [ a
-                            [ href "#"
-                            , onClick <| outMsg (SubjectChange category)
-                            , classList
-                                [ ( "selected"
-                                  , category == selectedCategory
-                                  )
-                                ]
-                            ]
-                            [ span [] [ text <| searchTypeToTitle category ]
-                            , closeButton
-                            ]
-                        ]
-                )
-                allTypes
-            )
-        ]
-    ]
-
-
-closeButton : Html a
-closeButton =
-    span [] []
-
-
-viewBucket :
-    String
-    -> List Search.AggregationsBucketItem
-    -> (String -> a)
-    -> List String
-    -> List (Html a)
-    -> List (Html a)
-viewBucket title buckets searchMsgFor selectedBucket sets =
-    List.append
-        sets
-        (if List.isEmpty buckets then
-            []
-
-         else
-            [ li []
-                [ ul []
-                    (List.append
-                        [ li [ class "header" ] [ text title ] ]
-                        (List.map
-                            (\bucket ->
-                                li []
-                                    [ a
-                                        [ href "#"
-                                        , onClick <| searchMsgFor bucket.key
-                                        , classList
-                                            [ ( "selected"
-                                              , List.member bucket.key selectedBucket
-                                              )
-                                            ]
-                                        ]
-                                        [ span [] [ text bucket.key ]
-                                        , if List.member bucket.key selectedBucket then
-                                            closeButton
-
-                                          else
-                                            span [] [ span [ class "badge" ] [ text <| String.fromInt bucket.doc_count ] ]
-                                        ]
-                                    ]
-                            )
-                            buckets
-                        )
-                    )
-                ]
-            ]
-        )