c8h4/aux-search
1
0
Fork 0
Code Issues Pull requests Packages Releases Activity

Discard effects when routing only query params (#229)

Browse source 
fixes #225
This commit is contained in:
Marek Fajkus 2020-11-19 00:49:15 +01:00 committed by GitHub
parent 7ac72dc89c
commit 29f5f02a16
Failed to generate hash of commit
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/Main.elm
View file

@ -160,7 +160,14 @@ changeRouteTo :
-> ( Model, Cmd Msg ) -> ( Model, Cmd Msg )
changeRouteTo currentModel url = changeRouteTo currentModel url =
let let
attempteQuery (( newModel, cmd ) as pair) = attempteQuery ( newModel, cmd ) =
let
-- We intentially throw away Cmd
-- because we don't want to perform any effects
-- in this cases where route itself doesn't change
noEffects =
( newModel, Cmd.none )
in
case ( currentModel.route, newModel.route ) of case ( currentModel.route, newModel.route ) of
( Route.Packages arg1, Route.Packages arg2 ) -> ( Route.Packages arg1, Route.Packages arg2 ) ->
if if
@ -173,7 +180,7 @@ changeRouteTo currentModel url =
submitQuery newModel ( newModel, cmd ) submitQuery newModel ( newModel, cmd )
else else
pair noEffects
( Route.Options arg1, Route.Options arg2 ) -> ( Route.Options arg1, Route.Options arg2 ) ->
if if
@ -186,14 +193,14 @@ changeRouteTo currentModel url =
submitQuery newModel ( newModel, cmd ) submitQuery newModel ( newModel, cmd )
else else
pair noEffects
( a, b ) -> ( a, b ) ->
if a /= b then if a /= b then
submitQuery newModel ( newModel, cmd ) submitQuery newModel ( newModel, cmd )
else else
pair noEffects
in in
case Route.fromUrl url of case Route.fromUrl url of
Nothing -> Nothing ->