feat: C template #27

Merged
Sigmanificient merged 7 commits from c into main 2024-05-14 20:24:13 +00:00
10 changed files with 82 additions and 119 deletions
Showing only changes of commit d981bc409e - Show all commits

2
c/.gitattributes vendored
View file

@ -1,2 +0,0 @@
* text=lf
* eol=lf

63
c/.gitignore vendored
View file

@ -1,15 +1,64 @@
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# binaries # binaries
hello hello
# build # language support
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.[aod]
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# config
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
compile_commands.json compile_commands.json
.pre-commit-config.yaml
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
.cache .cache
# nix # nix
.direnv .direnv
.envrc result*
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
result repl-result-*
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Prerequisites
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.d
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Object files
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.o
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.ko
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.obj
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.elf
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Linker output
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.ilk
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.map
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.exp
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Precompiled Headers
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.gch
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.pch
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Libraries
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.lib
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.a
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.la
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.lo
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Shared objects (inc. Windows DLLs)
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.dll
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.so
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.so.*
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.dylib
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Executables
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.exe
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.out
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.app
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.i*86
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.x86_64
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.hex
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Debug files
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.dSYM/
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.su
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.idb
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.pdb
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# Kernel Module Compile Results
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.mod*
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.cmd
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
.tmp_versions/
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
modules.order
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
Module.symvers
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
Mkfile.old
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
dkms.conf
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

View file

@ -1,29 +0,0 @@
# Credit to Mitchell Hashimoto
# post: https://mitchellh.com/writing/nix-with-dockerfiles
# Nix builder
FROM nixos/nix:latest AS builder
# Copy our source and setup our working dir.
COPY . /tmp/build
WORKDIR /tmp/build
# Build our Nix environment
RUN nix \
--extra-experimental-features "nix-command flakes" \
--option filter-syscalls false \
build
# Copy the Nix store closure into a directory. The Nix store closure is the
# entire set of Nix store values that we need for our build.
RUN mkdir /tmp/nix-store-closure
RUN cp -R $(nix-store -qR result/) /tmp/nix-store-closure
# Final image is based on scratch. We copy a bunch of Nix dependencies
# but they're fully self-contained so we don't need Nix anymore.
FROM scratch
# Copy /nix/store
COPY --from=builder /tmp/nix-store-closure /nix/store
COPY --from=builder /tmp/build/result /app
CMD ["/app/bin/hello"]

View file

@ -1,21 +1,12 @@
.POSIX:
.SUFFIXES: .o
CC ?= gcc CC ?= gcc
CFLAGS += -pedantic -Wall -Wextra -O2
OUT := hello OUT := hello
BINDIR ?= /usr/bin
SRC += main.c SRC += main.c
OBJ := $(SRC:.c=.o) OBJ := $(SRC:.c=.o)
CFLAGS += @compile_flags.txt
CFLAGS += -ffunction-sections -fdata-sections
LDFLAGS := -fwhole-program -flto
LDFLAGS += -Wl,--gc-sections -s
RM ?= rm -f
.DEFAULT_GOAL: all
.PHONY: all .PHONY: all
all: $(OUT) all: $(OUT)
@ -33,3 +24,7 @@ fclean: clean
.PHONY: re .PHONY: re
.NOTPARALLEL: re .NOTPARALLEL: re
re: fclean all re: fclean all
.PHONY: install
install:
install -D hello ${BINDIR}/hello --mode 0755

View file

@ -1,18 +0,0 @@
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-std=c99
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-pedantic
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-pipe
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wall
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wcast-qual
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wconversion
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Werror=return-type
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Werror=vla-larger-than=0
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wextra
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wmissing-prototypes
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wshadow
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wstrict-prototypes
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-Wwrite-strings
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-O2
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-march=native
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here
-mtune=native
getchoo commented 2024-05-07 06:20:12 +00:00 (Migrated from github.com)
Review

why assume this?

```suggestion ``` why assume this?
getchoo commented 2024-05-07 06:21:18 +00:00 (Migrated from github.com)
Review

there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary

```suggestion ``` there's no reason to use these by default. it will only be confusing if anyone shares a locally built binary
Sigmanificient commented 2024-05-07 07:55:13 +00:00 (Migrated from github.com)
Review

I think that C99 is a very good standard to based a template on

I think that C99 is a very good standard to based a template on
getchoo commented 2024-05-07 09:45:20 +00:00 (Migrated from github.com)
Review

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

most people also aren't using c99 anymore. i feel this is just your personal taste here

> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference most people also aren't using c99 anymore. i feel this is just your personal taste here

View file

@ -1,13 +0,0 @@
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
{ stdenv, gnumake }:
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
stdenv.mkDerivation {
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
name = "hello";
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
src = ./.;
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
nativeBuildInputs = [ gnumake ];
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
enableParallelBuilding = true;
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
installPhase = ''
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
install -D hello $out/bin/hello --mode 0755
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
'';
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required
}
getchoo commented 2024-05-07 06:31:09 +00:00 (Migrated from github.com)
Review

make is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead

nativeBuildInputs = [ cmake ];
nativeBuildInputs = [ meson ninja ];
```suggestion ``` `make` is in stdenv, so i'm not sure we need this? also if you were to switch to meson/cmake, this would need to be replaced with one of these instead ```nix nativeBuildInputs = [ cmake ]; ``` ```nix nativeBuildInputs = [ meson ninja ]; ```
getchoo commented 2024-05-07 06:33:08 +00:00 (Migrated from github.com)
Review
  installPhase = ''
    runHook preInstall

    install -Dm755 hello $out/bin/hello
    
    runHook postInstall
  '';

this is also another reason to use cmake or meson: this phase wouldn't be required

```suggestion installPhase = '' runHook preInstall install -Dm755 hello $out/bin/hello runHook postInstall ''; ``` this is also another reason to use cmake or meson: this phase wouldn't be required

View file

@ -8,37 +8,20 @@
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
let let
forAllSystems = forAllSystems =
function: function:
nixpkgs.lib.genAttrs [ nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
"x86_64-linux" system: function nixpkgs.legacyPackages.${system}
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
"aarch64-linux" );
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
"x86_64-darwin"
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
"aarch64-darwin"
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
"i686-linux"
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
"mipsel-linux"
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
"powerpc64le-linux"
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
] (system: function nixpkgs.legacyPackages.${system});
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
in in
rec { rec {
devShells = forAllSystems (pkgs: { devShells = forAllSystems (pkgs: {
default = pkgs.mkShell { default = pkgs.mkShell { inputsFrom = [ packages.${pkgs.system}.hello ]; };
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
hardeningDisable = [ "fortify" ];
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
inputsFrom = pkgs.lib.attrsets.attrValues packages;
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
};
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
}); });
packages = forAllSystems (pkgs: rec { packages = forAllSystems (pkgs: rec {
isabelroses commented 2024-05-06 22:16:27 +00:00 (Migrated from github.com)
Review

Can we move the package defection to a file called default.nix

Can we move the package defection to a file called default.nix
Sigmanificient commented 2024-05-06 22:20:00 +00:00 (Migrated from github.com)
Review

Can we move the package defection to a file called default.nix

Is there a need to split the flake? it is quite small

> Can we move the package defection to a file called default.nix Is there a need to split the flake? it is quite small
isabelroses commented 2024-05-06 22:36:00 +00:00 (Migrated from github.com)
Review

It allows it to have old nix compatibility. that’s the main thing for me. Also prevents redeclaring the package a few times.

It allows it to have old nix compatibility. that’s the main thing for me. Also prevents redeclaring the package a few times.
default = hello; default = hello;
hello = pkgs.callPackage ./default.nix { }; hello = pkgs.callPackage ./hello.nix { };
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
}); });
isabelroses commented 2024-05-06 22:16:50 +00:00 (Migrated from github.com)
Review

 overlays.default = final: prev: {
   hello = final.callPackage ./default.nix {};
 };

```suggestion overlays.default = final: prev: { hello = final.callPackage ./default.nix {}; }; ```
Sigmanificient commented 2024-05-06 22:20:26 +00:00 (Migrated from github.com)
Review

What does this do?

What does this do?
isabelroses commented 2024-05-06 22:37:19 +00:00 (Migrated from github.com)
Review

this allows the user to consume the overlay and it will be added the nixpkgs list. so i could use enviroment.systemPackages = [ pkgs.hello ]; instead.

this allows the user to consume the overlay and it will be added the nixpkgs list. so i could use `enviroment.systemPackages = [ pkgs.hello ];` instead.
Sigmanificient commented 2024-05-06 22:38:42 +00:00 (Migrated from github.com)
Review

doesn't this cause conflict with the nixpkgs's hello pkgs?

doesn't this cause conflict with the nixpkgs's [hello](https://github.com/NixOS/nixpkgs/blob/nixos-23.11/pkgs/by-name/he/hello/package.nix#L34) pkgs?
overlays.default = final: prev: { hello = final.callPackage ./default.nix { }; }; overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
apps = forAllSystems (pkgs: rec {
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
default = hello;
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
hello = {
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
program = "${packages.${pkgs.system}.hello}/bin/hello";
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
type = "app";
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
};
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
});
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
}; };
} }

isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`
isabelroses commented 2024-05-06 22:13:05 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

        hello = pkgs.stdenv.mkDerivation {
          pname = "hello";

          src = ./.;
          nativeBuildInputs = [ pkgs.gnumake ];

          enableParallelBuilding = true;
          V = 1;
          installPhase = ''
            install -D hello $out/bin/hello --mode 0755
          '';
I would prefer to not have rec, also i believe it is pname, not name ```suggestion hello = pkgs.stdenv.mkDerivation { pname = "hello"; src = ./.; nativeBuildInputs = [ pkgs.gnumake ]; enableParallelBuilding = true; V = 1; installPhase = '' install -D hello $out/bin/hello --mode 0755 ''; ```
isabelroses commented 2024-05-06 22:16:46 +00:00 (Migrated from github.com)
Review
        hello = pkgs.callPackage ./default.nix {};
```suggestion hello = pkgs.callPackage ./default.nix {}; ```
TheCodedProf commented 2024-05-06 22:15:23 +00:00 (Migrated from github.com)
Review

Please change the description to something more related to C

Please change the description to something more related to C
Sigmanificient commented 2024-05-06 22:19:31 +00:00 (Migrated from github.com)
Review

I would prefer to not have rec, also i believe it is pname, not name

for mkDerivation it's name: otherwise it would throw error: attribute 'name' missing

> I would prefer to not have rec, also i believe it is pname, not name for `mkDerivation` it's name: otherwise it would throw `error: attribute 'name' missing`
getchoo commented 2024-05-07 06:24:08 +00:00 (Migrated from github.com)
Review
        nixpkgs.lib.genAttrs
        nixpkgs.lib.systems.flakeExposed
        (system: function nixpkgs.legacyPackages.${system});
```suggestion nixpkgs.lib.genAttrs nixpkgs.lib.systems.flakeExposed (system: function nixpkgs.legacyPackages.${system}); ```
getchoo commented 2024-05-07 06:24:50 +00:00 (Migrated from github.com)
Review

im not really sure why this is set?

im not really sure why this is set?
getchoo commented 2024-05-07 06:25:15 +00:00 (Migrated from github.com)
Review
          inputsFrom = [ packages.${pkgs.system}.hello ];
```suggestion inputsFrom = [ packages.${pkgs.system}.hello ]; ```
getchoo commented 2024-05-07 06:26:34 +00:00 (Migrated from github.com)
Review
      overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; };

we really only need to use final when passing arguments to callPackage

```suggestion overlays.default = final: prev: { hello = prev.callPackage ./default.nix { }; }; ``` we really only need to use `final` when passing arguments to callPackage
getchoo commented 2024-05-07 06:27:21 +00:00 (Migrated from github.com)
Review

this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use nix run and nix run .#hello without this

```suggestion ``` this isn't what the app output is really meant for, and doesn't actually introduce anything new. users can still use `nix run` and `nix run .#hello` without this
Sigmanificient commented 2024-05-07 08:25:22 +00:00 (Migrated from github.com)
Review

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

To me it would make more sense for this to be dynamic, because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell
getchoo commented 2024-05-07 09:49:10 +00:00 (Migrated from github.com)
Review

because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell

slightly different builds of the same package. this is done in prismlauncher for example

this also duplicates inputs due to the default package (which only really slows eval time a bit, but still) and currently doesn't work at all

lib.attrValues packages evaluates to [ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]

> because i cant think of a scenario where you wouldn't add the build inputs of a package within the dev shell slightly different builds of the same package. this is done in [prismlauncher](https://github.com/prismlauncher/prismlauncher) for example this also duplicates inputs due to the `default` package (which only really slows eval time a bit, but still) and currently doesn't work at all `lib.attrValues packages` evaluates to `[ { default = { ... }; hello = { ... }; } { default = { ... }; hello = { ... }; } { ... } ]`

7
c/hello.nix Normal file
View file

@ -0,0 +1,7 @@
{ stdenv }:
stdenv.mkDerivation {
name = "hello";
src = ./.;
env.BINDIR = "${placeholder "out"}/bin";
}

View file

@ -1,16 +1,11 @@
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
#include <stdio.h>
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
#include <stdlib.h> #include <stdlib.h>
#include <unistd.h>
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
#define lengthof(sstr) (sizeof (sstr) / sizeof *(sstr))
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
#define sstr_len(sstr) (lengthof(sstr) - 1)
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
#define sstr_unpack(sstr) (sstr), (sstr_len(sstr))
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
static const char GREETING[] = "hello, world!\n";
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
int main(void) int main(void)
{ {
return ( char greet[] = "hello, world!\n";
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
write(STDOUT_FILENO, sstr_unpack(GREETING)) int written = printf("%s", greet);
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
== sstr_len(GREETING)
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
) ? EXIT_SUCCESS : EXIT_FAILURE; return written == (sizeof(greet) - 1)
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
? EXIT_SUCCESS : EXIT_FAILURE;
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
} }

getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`
getchoo commented 2024-05-07 06:29:54 +00:00 (Migrated from github.com)
Review
#include <stdio.h>

int main(int argc, char *argv[]) {
    printf("Hello from Aux!\n");
    return 0;
}

we really don't need to overcomplicate this

```suggestion #include <stdio.h> int main(int argc, char *argv[]) { printf("Hello from Aux!\n"); return 0; } ``` we really don't need to overcomplicate this
Sigmanificient commented 2024-05-07 08:20:21 +00:00 (Migrated from github.com)
Review

write is lighter than printf. I think it is better to use it, and i am not sure by what means it is overcomplicated?

`write` is lighter than `printf`. I think it is better to use it, and i am not sure by what means it is overcomplicated?
Austreelis commented 2024-05-07 09:17:17 +00:00 (Migrated from github.com)
Review

I agree with getchoo.
I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway.

I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.

I agree with getchoo. I think defining macros when it's arguably not needed is overcomplicating it. Also, I think we really don't care about the performance of printf vs write here. Getchoo's suggestion is the canonical hello world C program, it doesn't bring in any header other than stdlib, it doesn't define any item besides main (which you probably need), and it's recognizable so people know they should scrap it anyway. I feel like the template should focus on nix code, and completely disregard C code (unless it demonstrates something on the nix side). I'd even be fine with an empty source file if that compiled.
getchoo commented 2024-05-07 09:51:14 +00:00 (Migrated from github.com)
Review

write is lighter than printf

i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference

and i am not sure by what means it is overcomplicated?

i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this

> write is lighter than printf >> i feel this is once again putting a lot of focus on what is really just throwaway example code. i would really take a look at https://github.com/NixOS/templates/tree/master/c-hello as a reference > and i am not sure by what means it is overcomplicated? i don't think we're really going to get anywhere with this question being asked, so i would rather not continue with this
Sigmanificient commented 2024-05-07 09:56:23 +00:00 (Migrated from github.com)
Review

i genuinely don't get it, but i changed the implementation to use a regular printf

i genuinely don't get it, but i changed the implementation to use a regular `printf`

View file

@ -1,4 +0,0 @@
columns = 80
sort = "lines"
types = ["C", "C Header", "Makefile", "Markdown"]
treat_doc_strings_as_comments = true