feat: C template #27

Merged
Sigmanificient merged 7 commits from c into main 2024-05-14 20:24:13 +00:00
5 changed files with 72 additions and 0 deletions
Showing only changes of commit c1524d5bd9 - Show all commits

22
c/.editorconfig Normal file
View file

@ -0,0 +1,22 @@
root = true
[*]
charset = utf-8
end_of_line = lf
indent_size = 4
indent_style = space
insert_final_newline = true
max_line_length = 80
tab_width = 4
[{Makefile,*.mk}]
indent_style = tab
[*.nix]
indent_style = space
tab_width = 2
indent_size = 2
[*.lock]
indent_style = unset
insert_final_newline = unset

2
c/.gitattributes vendored Normal file
View file

@ -0,0 +1,2 @@
* text=lf
* eol=lf

15
c/.gitignore vendored Normal file
View file

@ -0,0 +1,15 @@
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# binaries
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
hello
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# build
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
*.[aod]
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# config
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
compile_commands.json
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
.pre-commit-config.yaml
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
.cache
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
# nix
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
.direnv
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
.envrc
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other
result
getchoo commented 2024-05-07 06:16:38 +00:00 (Migrated from github.com)
Review

this can be commited, as long as it doesn't assume nix is installed. this can work for example

if has nix_direnv_version; then
  use flake
fi
```suggestion ``` this can be commited, as long as it doesn't assume nix is installed. this can work for example ``` if has nix_direnv_version; then use flake fi ```
getchoo commented 2024-05-07 06:16:48 +00:00 (Migrated from github.com)
Review
result*
repl-result-*
```suggestion result* repl-result-* ```
getchoo commented 2024-05-07 06:37:19 +00:00 (Migrated from github.com)
Review

these are all unused

```suggestion ``` these are all unused
getchoo commented 2024-05-07 06:38:00 +00:00 (Migrated from github.com)
Review

when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched

```suggestion ``` when using cmake or meson with github's template, these are not necessary as we have a standard build directory and file extensions are already matched
Sigmanificient commented 2024-05-07 07:18:21 +00:00 (Migrated from github.com)
Review

Only the .pre-commit-config.yaml is unused so I'll remove it.

I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like .cache or compile_commands.json that are useful, it seems like a contradiction?

Only the `.pre-commit-config.yaml` is unused so I'll remove it. I'm not sure why do you want to include entries unrelated to this template in the gitignore but also removing important ignore like `.cache` or `compile_commands.json` that are useful, it seems like a contradiction?
Sigmanificient commented 2024-05-07 07:20:22 +00:00 (Migrated from github.com)
Review

Committing a .envrc doesn't seems like a good practice to me.
I can remove that entry tho, so it's up to the user to decide was to do i they use direnv

Committing a `.envrc` doesn't seems like a good practice to me. I can remove that entry tho, so it's up to the user to decide was to do i they use direnv
Sigmanificient commented 2024-05-07 07:22:29 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

I cant find any public gitignore using `repl-result-*`, so it sound like something we may not need
getchoo commented 2024-05-07 09:22:12 +00:00 (Migrated from github.com)
Review

yeah this would be better removed

yeah this would be better removed
getchoo commented 2024-05-07 09:22:43 +00:00 (Migrated from github.com)
Review

I cant find any public gitignore using repl-result-*, so it sound like something we may not need

if you use :bl in a repl, you do. this is a known nix artifact, same as result*

> I cant find any public gitignore using repl-result-*, so it sound like something we may not need if you use `:bl` in a repl, you do. this is a known nix artifact, same as `result*`
getchoo commented 2024-05-07 09:53:53 +00:00 (Migrated from github.com)
Review

important ignore like .cache or compile_commands.json

the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either

> important ignore like .cache or compile_commands.json the only reason they are important is because of the specific way you have this set up. other projects are very unlikely to use these, and i would say they shouldn't be used here either
Sigmanificient commented 2024-05-07 10:06:12 +00:00 (Migrated from github.com)
Review

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

This is the same scenario with the other GitHub ignore you wanted me to include, I think either both should be put or none, because it doesn't seem logic to add one and not the other

29
c/Dockerfile Normal file
View file

@ -0,0 +1,29 @@
# Credit to Mitchell Hashimoto
# post: https://mitchellh.com/writing/nix-with-dockerfiles
# Nix builder
FROM nixos/nix:latest AS builder
# Copy our source and setup our working dir.
COPY . /tmp/build
WORKDIR /tmp/build
# Build our Nix environment
RUN nix \
--extra-experimental-features "nix-command flakes" \
--option filter-syscalls false \
build
# Copy the Nix store closure into a directory. The Nix store closure is the
# entire set of Nix store values that we need for our build.
RUN mkdir /tmp/nix-store-closure
RUN cp -R $(nix-store -qR result/) /tmp/nix-store-closure
# Final image is based on scratch. We copy a bunch of Nix dependencies
# but they're fully self-contained so we don't need Nix anymore.
FROM scratch
# Copy /nix/store
COPY --from=builder /tmp/nix-store-closure /nix/store
COPY --from=builder /tmp/build/result /app
CMD ["/app/bin/hello"]

4
c/tokei.toml Normal file
View file

@ -0,0 +1,4 @@
columns = 80
sort = "lines"
types = ["C", "C Header", "Makefile", "Markdown"]
treat_doc_strings_as_comments = true