use standard module system more over specialArgs #3

Merged

getchoo merged 2 commits from modules into main

2024-05-02 09:31:39 +00:00

getchoo commented

2024-05-01 22:05:47 +00:00

(Migrated from github.com)

currently, the use of specialArgs has a large overlap with standard (and documented) configuration options. i think we should be using these through config instead, rather than setting the example of passing simple string values like these to specialArgs only to use them in one or two options. this would:

show newer users that this is possible and a good way to reuse values for anything they configure
keep these templates away from being too "alien" compared to the existing nix ecosystem
give more examples of how the modules argument works outside of just taking in paths to files

currently, the use of specialArgs has a large overlap with standard (and documented) configuration options. i think we should be using these through `config` instead, rather than setting the example of passing simple string values like these to specialArgs only to use them in one or two options. this would: - show newer users that this is possible and a good way to reuse values for anything they configure - keep these templates away from being too "alien" compared to the existing nix ecosystem - give more examples of how the `modules` argument works outside of just taking in paths to files

isabelroses (Migrated from github.com) approved these changes 2024-05-02 00:02:18 +00:00

jakehamilton (Migrated from github.com) reviewed 2024-05-02 00:10:58 +00:00

home-manager/flake.nix

jakehamilton (Migrated from github.com) commented

2024-05-02 00:08:55 +00:00

I believe we will want to prefer the prefix version of this inputs @ { as opposed to suffix.

I believe we will want to prefer the prefix version of this `inputs @ {` as opposed to suffix.

system/configuration.nix

jakehamilton (Migrated from github.com) commented

2024-05-02 00:10:38 +00:00

This is adorable. Well done.

Minion3665 (Migrated from github.com) requested changes 2024-05-02 00:20:54 +00:00

Minion3665 (Migrated from github.com) left a comment

Overall some very nice changes. There's a couple of review comments and GitHub tells me of a conflict, but overall extremely minor things.

I have to go now, but please don't worry if you don't have time to solve them by tomorrow. If that's the case then I'll rebase this branch and make another commit fixing those review comments

Overall some very nice changes. There's a couple of review comments and GitHub tells me of a conflict, but overall extremely minor things. I have to go now, but please don't worry if you don't have time to solve them by tomorrow. If that's the case then I'll rebase this branch and make another commit fixing those review comments

system/configuration.nix

Minion3665 (Migrated from github.com) commented

2024-05-02 00:16:03 +00:00

If we're doing this, we should remember to also update the README to fix the reference

This is better for not assuming the single-user case as much, possibly slightly worse if people are running commands without properly reading what they're doing but I guess it's probably fine...

If we're doing this, we should remember to also update the README to fix the reference This is better for not assuming the single-user case as much, possibly slightly worse if people are running commands without properly reading what they're doing but I guess it's probably fine...

Minion3665 commented

2024-05-02 00:22:03 +00:00

(Migrated from github.com)

Oops -- looks like my review was largely outdated by your speedy work. Sorry & thanks

No reviewers

isabelroses

Minion3665

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: auxolotl/templates#3

No description provided.