CI to ensure formatting? #24

New issue

Closed

opened 2024-05-05 10:29:00 +00:00 by AxelSilverdew · 3 comments

AxelSilverdew commented

2024-05-05 10:29:00 +00:00

(Migrated from github.com)

To ensure that templates are always formatted properly, should we include a simple CI check to make sure that PRs are always formatted with nixfmt before we merge them?

Forgejo is compatible with the github actions yml, so when we move over the CI will move over too, so this won't be tying us down to GitHub in any way.

To ensure that templates are always formatted properly, should we include a simple CI check to make sure that PRs are always formatted with nixfmt before we merge them? Forgejo is compatible with the github actions yml, so when we move over the CI will move over too, so this won't be tying us down to GitHub in any way.

❤️ 2

liketechnik commented

2024-05-05 13:00:38 +00:00

(Migrated from github.com)

Yes please, see also the discussion at https://forum.aux.computer/t/reviewing-and-merging-pr-mrs/316/15?u=liketechnik:

If you like it, put a lint rule on it

A large amount of the nits can be taken care of via automation (formatter, linter, tests). We should not have to waste effort on these things.

Yes please, see also the discussion at https://forum.aux.computer/t/reviewing-and-merging-pr-mrs/316/15?u=liketechnik: >> If you like it, put a lint rule on it > A large amount of the nits can be taken care of via automation (formatter, linter, tests). We should not have to waste effort on these things.

👍 1

AxelSilverdew commented

2024-05-05 13:03:23 +00:00

(Migrated from github.com)

Alrighty, gonna open a PR with this then.

🚀 1

AxelSilverdew commented

2024-05-05 14:03:46 +00:00

(Migrated from github.com)

Opened a PR here: https://github.com/auxolotl/templates/pull/25