Use the module system for bootstrapping variables #20

New issue

Open

opened 2024-05-03 09:54:22 +00:00 by NotAShelf · 2 comments

NotAShelf commented

2024-05-03 09:54:22 +00:00

(Migrated from github.com)

The current implementation of userspace variables (system, hostname, etc...) is a common, yet not very very robust pattern. I suggest that it is advised against, and replaced with a very tiny module system inside the flake. This will not only get rid of the current solution that's going to nag the user, or worse, push them to use specialArgs for those variables but also introduce them to the module system.

I propose (and am willing to implement) replacing those examples with instances of the module system in the templates.

The current implementation of userspace variables (system, hostname, etc...) is a common, yet not very very robust pattern. I suggest that it is advised *against*, and replaced with a very tiny module system inside the flake. This will not only get rid of the current solution that's going to nag the user, or worse, push them to use `specialArgs` for those variables but also introduce them to the module system. I propose (and am willing to implement) replacing those examples with instances of the module system in the templates.

👍 5 👀 1

isabelroses commented

2024-05-03 16:48:18 +00:00

(Migrated from github.com)

(and am willing to implement)

If your still willing to implement this please feel free to open a PR.

> (and am willing to implement) If your still willing to implement this please feel free to open a PR.

NotAShelf commented

2024-05-03 17:06:56 +00:00

(Migrated from github.com)

Just wanted to collect comments before I made the PR, will work on the impl tomorrow.

❤️ 3

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: auxolotl/templates#20

No description provided.