pass nixpkgs directly in forAllSystems, fix typos #2

Merged

getchoo merged 2 commits from pass-pkgs into main

2024-05-02 00:07:56 +00:00

getchoo commented

2024-05-01 21:44:24 +00:00

(Migrated from github.com)

Giving system directly as an argument is more annoying in most situations than not - a good example being how the formatter output is set. Passing nixpkgs.legacyPackages.${system} directly allows for more concise access to what callers usually want (pkgs), and can also help avoid boilerplate in other situations (i.e., destructuring pkgs into {lib, pkgs, system, ...} instead of system: let pkgs = nixpkgs.legacyPackages.${system}; inherit (pkgs) lib; in ...)

Giving `system` directly as an argument is more annoying in most situations than not - a good example being how the formatter output is set. Passing `nixpkgs.legacyPackages.${system}` directly allows for more concise access to what callers usually want (`pkgs`), and can also help avoid boilerplate in other situations (i.e., destructuring `pkgs` into `{lib, pkgs, system, ...}` instead of `system: let pkgs = nixpkgs.legacyPackages.${system}; inherit (pkgs) lib; in ...`)

❤️ 1

isabelroses (Migrated from github.com) approved these changes 2024-05-01 21:47:29 +00:00

Minion3665 (Migrated from github.com) approved these changes 2024-05-02 00:07:50 +00:00

Minion3665 (Migrated from github.com) left a comment

Let's do it, thanks Getchoo!

No reviewers

isabelroses

Minion3665

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: auxolotl/templates#2

No description provided.