tidepool: some work towards successfully doing a strict eval #57

5225225 · 2025-12-03T11:57:27Z

5225225 commented

2025-12-03 11:57:27 +00:00

First-time contributor

not complete, but fixes some issues.
see #50

not complete, but fixes some issues. see https://git.auxolotl.org/auxolotl/labs/issues/50

5225225 added 1 commit 2025-12-03 11:57:35 +00:00

tidepool: some work towards successfully doing a strict eval 3ee68421db

not complete, but fixes some issues.
see #50

5225225 reviewed 2025-12-03 12:01:55 +00:00

tidepool/src/lib/types.nix Outdated

					
				@ -366,3 +366,2 @@

				      platforms = {

				        build = lib.types.attrs.of lib.types.platforms.host;

				        host = lib.types.attrs.of lib.types.platforms.host;

				        build = lib.types.any;

5225225 commented

2025-12-03 12:01:55 +00:00

First-time contributor

this is the most dubious change, but also i don't know how this worked before?

(using lib.types.attrs.lazy doesn't change anything)

that and if this corresponds to the platforms.build in a derivation, they can be both a string / list / attrset so i guess the previous type was incorrect? or it doesn't matter? idk. someone who knows more nix than me correct me on that.

this is the most dubious change, but also i don't know how this worked before? (using lib.types.attrs.lazy doesn't change anything) that and if this corresponds to the `platforms.build` in a derivation, they can be both a string / list / attrset so i *guess* the previous type was incorrect? or it doesn't matter? idk. someone who knows more nix than me correct me on that.

5225225 marked this conversation as resolved

srd424 commented

2025-12-03 12:47:03 +00:00

Hydra is happy: https://hydra.aux-cache.dev/jobset/aux-prs/labs-pr57 (the one build failure was already there.)

RossSmyth reviewed 2025-12-03 17:10:01 +00:00

tidepool/src/lib/types.nix Outdated

					
				@ -364,8 +364,8 @@ in

				        lib.types.coerce initial transform final;

				      platforms = {

				        build = lib.types.attrs.of lib.types.platforms.host;

RossSmyth commented

2025-12-03 17:10:01 +00:00

Everything else looks good. This change I think could probably be removed, and then I think the proper place for fixing this is at lib/types.nix somewhere.

Everything else looks good. This change I think could probably be removed, and then I think the proper place for fixing this is at `lib/types.nix` somewhere.

5225225 commented

2025-12-03 18:08:40 +00:00

First-time contributor

reverted just that change

5225225 marked this conversation as resolved

5225225 added 1 commit 2025-12-03 18:08:09 +00:00

revert change of build/host platform 444373b28c

RossSmyth approved these changes 2025-12-03 22:26:48 +00:00

RossSmyth left a comment

:3

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u fix-some-eval-issues:5225225-fix-some-eval-issues

git checkout 5225225-fix-some-eval-issues

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff 5225225-fix-some-eval-issues

git checkout 5225225-fix-some-eval-issues

git rebase main

git checkout main

git merge --ff-only 5225225-fix-some-eval-issues

git checkout 5225225-fix-some-eval-issues

git rebase main

git checkout main

git merge --no-ff 5225225-fix-some-eval-issues

git checkout main

git merge --squash 5225225-fix-some-eval-issues