fix(lib): swapped entries in test dag.sort.topological."sorts a graph" (#9)
Some checks failed
buildbot/nix-eval Build done.
Some checks failed
buildbot/nix-eval Build done.
I figure it's a simple typo. This test expects entries `"a"`, `"b"`, `"c"`, `"d"` to be lexicographically sorted but fails. The actual result is that entries are sorted in this order: `c, b, a, d`. This is because the test adds the entry `"b" = lib.dag.entry.between [ "c" ] [ "a" ] "b"`, i.e. after `"c"` and before `"a"`. I haven't checked if it was a logic error in the sort implementation, as other pieces of labs rely on it (and use `lib.dag.entry.between` with the arguments flipped relative to the test, which makes sense), and the arguments of the function `lib.dag.entry.between` are named "after", *then* "before". Co-authored-by: Austreelis <dev.austreelis@swhaele.net> Reviewed-on: #9 Reviewed-by: Jake Hamilton <jake.hamilton@hey.com> Co-authored-by: Austreelis <austreelis@noreply.git.auxolotl.org> Co-committed-by: Austreelis <austreelis@noreply.git.auxolotl.org>
This commit is contained in:
parent
d7762a5a78
commit
866b8902c9
|
@ -149,7 +149,7 @@ in
|
|||
];
|
||||
actual = lib.dag.sort.topological {
|
||||
a = lib.dag.entry.anywhere "a";
|
||||
b = lib.dag.entry.between [ "c" ] [ "a" ] "b";
|
||||
b = lib.dag.entry.between [ "a" ] [ "c" ] "b";
|
||||
c = lib.dag.entry.before [ "c" ] "c";
|
||||
d = lib.dag.entry.after [ "c" ] "d";
|
||||
};
|
||||
|
|
Loading…
Reference in a new issue