fetchFromGitLab: force re-fetch when rev changes #14
No reviewers
Labels
No labels
Compat
Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: auxolotl/core#14
Loading…
Reference in a new issue
No description provided.
Delete branch "bbjubjub2494/fetchfromgitlab"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
There are a few instances of
fetchFromGitLab
in the repo, for instancegtk-doc.src
.My primary goal when writing this was changing the output derivation following #11. This is doable with a lot less diff in
fetchFromGitLab
, but it's worth asking whether both fetchers should be different and why. I think a lot of the divergence comes from years of random commits rather than from design.I'd be inclined to rework both, and use what exists now as a base for a generic
fetchFromGitForge
that bothfetchFromGitHub
andfetchFromGitlab
can be defined in terms of.I tried working on the refactor in a branch, but I am not comfortable writing such code for production because there seem to be too many small details in the original code like complex passthroughs and unsafe functions that I don't know the purpose of.
https://github.com/bbjubjub2494/auxolotl_core/tree/fetchfromgitforge
I would suggest we do the minimal diff thing for now
I think we should be good to merge this. This shouldn't cause a rebuild since the source is identical right.
Just tested with busybox, it looks like it does cause a rebuild
The more I think about it the less important the rebuild is since we are providing our own package versions anyways. So I think we can just ignore rebuilds for the time being.
Doesn't seem to have caused a rebuild on hydra, I don't know it should have! (I've only got jobs for stdenv and lix set-up so far.)
I believe this PR was only for gitlab sources, perhaps make a gitlab test?
Ah, I wasn't attempting to test so much as provide feedback on whether it caused a rebuild!