auxolotl/buildbot-nix
26
1
Fork 0
Code Issues Pull requests 1 Actions 1 Packages Projects Releases Wiki Activity

fix: Correct output path with failed builds
Some checks failed
buildbot/nix-eval Build done.
Details

Browse source 
Previously, if a build failed to produce any output we would try to
write "None" to the output file. This doesn't work, causing the job to
error. Instead, we should skip writing the output and preserve the
original "failed" status.
This commit is contained in:
Skyler Grey 2024-09-11 20:01:13 +00:00
parent 46800094bb
commit a0784bf027
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
buildbot_nix/__init__.py
View file

@ -339,6 +339,11 @@ class UpdateBuildOutput(steps.BuildStep):
if not pr and props.getProperty("branch") != self.project.default_branch: if not pr and props.getProperty("branch") != self.project.default_branch:
return util.SKIPPED return util.SKIPPED
out_path = props.getProperty("out_path")
if not out_path: # if, e.g., the build fails and doesn't produce an output
return util.SKIPPED
owner = Path(props.getProperty("owner")) owner = Path(props.getProperty("owner"))
repo = Path(props.getProperty("repository_name")) repo = Path(props.getProperty("repository_name"))
@ -355,7 +360,6 @@ class UpdateBuildOutput(steps.BuildStep):
file.parent.mkdir(parents=True, exist_ok=True) file.parent.mkdir(parents=True, exist_ok=True)
out_path = props.getProperty("out_path")
file.write_text(out_path) file.write_text(out_path)
return util.SUCCESS return util.SUCCESS